feat: restrict-plus-operands: improve diagnostic#725
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 22, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camchenry
changed the title
restrict-plus-operands: improve diagnosticrestrict-plus-operands: improve diagnostic
57 tasks
graphite-app
bot
changed the base branch from
02-21-feat_restrict-template-expressions_move_type_to_labeled_range
to
graphite-base/725
camc314
approved these changes
Feb 22, 2026
Contributor
Merge activity
|
NOTE: There is an issue with help messages not showing up in snapshots, I will fix this in the following PR. This rule's error message is packed with both type information and help information (what types are allowed). I've moved the resolved type info to be labeled ranges, and moved the message about what types are allowed to the help message. This should keep the information a little bit more structured and not crowd the main error message as much.
graphite-app
bot
force-pushed
the
02-21-fea_restrict-plus-operands_improve_diagnostic
branch
from
ed87449 to
baedad5
Compare
graphite-app
bot
deleted the
02-21-fea_restrict-plus-operands_improve_diagnostic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: There is an issue with help messages not showing up in snapshots, I will fix this in the following PR.
This rule's error message is packed with both type information and help information (what types are allowed). I've moved the resolved type info to be labeled ranges, and moved the message about what types are allowed to the help message. This should keep the information a little bit more structured and not crowd the main error message as much.