add missing parsing for modal modules #117
Open
+454
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when there are no functor args, moving modes from constraint to identifier should not be a semantic change Signed-off-by: David Vulakh <[email protected]>
the normalization happens in the parsrer now Signed-off-by: David Vulakh <[email protected]>
riaqn
commented
Sep 3, 2025
vendor/parser-extended/ast_helper.ml
Outdated
Comment on lines
436
to
437
| (* Special case: when this module binding is not a functor, and the module expression | ||
| is a constraint with modes, move the modes to the binding *) |
There was a problem hiding this comment.
Can we move this to Fmt_ast or something? I think that parser-extended should represent user input faithfully (for better print back).
(In contrast, parser-standard is fine to manipulate user input)
There was a problem hiding this comment.
Not relevant to this PR since we decided to wait for compiler support before moving these modes, but fwiw: we often do normalization directly in the extended parser to avoid duplicating normalization logic in fmt_ast and normalize_extended_ast (note that we already need to duplicate it in normalize_std_ast). For example, lists of modes are sorted alphabetically directly in the extended parser.
we will want to go back to putting modes on the ident when possible, but need the compiler to type check them better first Signed-off-by: David Vulakh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See added tests.