Peer stats follow up 2020 07 09#1318
Merged
majestrate merged 70 commits intooxen-io:devfrom Jul 27, 2020
Merged
Conversation
notlesh
commented
Jul 24, 2020
| if (numTries == maxTries) | ||
| throw; | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This deserves a closer look. The problem is that lokinet will try to immediately connect to lokid if configured to do so, and bails out ungracefully if it can't connect.
majestrate
approved these changes
Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds upon the previous peer stats work to integrate with
lokid. This adds a bt-encoded API endpoint for loki-core to hit and serializes data withloki-mq's bt-encoding framework.At the time of this writing, the only outstanding work (other than lots of testing) is to parse
lokid's list of RouterIds.The corresponding
loki-corePR is: oxen-io/oxen-core#1198