Augment localdevnet w/ optional storage server#1822
Open
Doy-lee wants to merge 32 commits intooxen-io:devfrom
Open
Augment localdevnet w/ optional storage server#1822Doy-lee wants to merge 32 commits intooxen-io:devfrom
Doy-lee wants to merge 32 commits intooxen-io:devfrom
Conversation
Collaborator
Doy-lee
commented
Apr 11, 2025
Doy-lee
commented
- Fix BLS logging truncated pubkeys incorrectly by repeating the wrong characters for the key
- Downgrade a log line that is emitted for each SN connection in BLS aggregation to trace
- Allow storage server ports to be set in localdevnet proofs
- Allow setting of a fixed IP address for the daemon to listen on in the localdevnet script to allow hardcoding of the seed node when connecting Session clients to the network
Closed
Doy-lee
force-pushed
the
doyle-localdevnet-storage-server
branch
4 times, most recently
from
c9a6ea3 to
1cd8b40
Compare
Doy-lee
force-pushed
the
doyle-localdevnet-storage-server
branch
3 times, most recently
from
76ad83c to
96b1a17
Compare
Doy-lee
force-pushed
the
doyle-localdevnet-storage-server
branch
from
2b7ba65 to
7761f06
Compare
Doy-lee
force-pushed
the
doyle-localdevnet-storage-server
branch
from
7761f06 to
a3164b7
Compare
Doy-lee
force-pushed
the
doyle-localdevnet-storage-server
branch
from
234f61c to
4deee3b
Compare
Doy-lee
force-pushed
the
doyle-localdevnet-storage-server
branch
from
bfdc289 to
9a0da0f
Compare
Doy-lee
force-pushed
the
doyle-localdevnet-storage-server
branch
from
9a0da0f to
ffb5daa
Compare
We avoid adding SNs via the ETH network if you just want to spin up a network to reduce the hardware requirements to run the network. The ETH sns code path introdces 6 additional SNs to the network. From anecdotal observations, some of the networking starts to spuriously fail, like, Pulse handshake bitsets are not getting correctly passed around even though peers are visible to each other causing block generation to fail. By spinning up a network without integration tests we can drop the SN's spawned to 12 nodes again which makes the network more reliable. With the addition of the storage server also running, this furthermore increases the hardware requirements for this private network to run.
…flag This array is only populated when the integration tests are enabled
…n wallet keep_data_dir was added as a field to the wallet which was a kludge to get things working but it unncessarily complicates adds yet more state that the wallet already handles using the 'existing' flag that already exists.
… chain in localdevnet
The thread ID is designed to be safe and cheap to copy (it's internally just an int, or, 4 bytes on a majority modern platforms). This member is used in different threads (i.e. the OMQ worker threads) and reads are atomic so it also helps with a potential race condition in certain contexts (like the local devnet).
Doy-lee
force-pushed
the
doyle-localdevnet-storage-server
branch
from
3bc6f52 to
7653a6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.