clippy lints #75
Open
clippy lints #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly mechanical fixes: removing needless borrows, adding lifetime annotations, using modern numeric constants (i32::MAX), and suppressing warnings for dropshot-generated dead code. Notable equivalences: - .as_bytes().len() to .len() on String: both return byte count - .trim().split_whitespace() to .split_whitespace(): split_whitespace already skips leading/trailing whitespace - .into_iter() to .iter() on slices: both yield &T
jclulow
requested changes
Dec 9, 2025
Collaborator
jclulow
left a comment
jclulow
left a comment
There was a problem hiding this comment.
This seems broadly good! A few nits.
| .arg("create") | ||
| .arg("-o") | ||
| .arg(&format!("mountpoint={}", INPUT_PATH)) | ||
| .arg(format!("mountpoint={}", INPUT_PATH)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| .arg(format!("mountpoint={}", INPUT_PATH)) | |
| .arg(format!("mountpoint={INPUT_PATH}")) |
| * assessed against the actual file size and a partial (206) response will be | ||
| * returned, for both GET and HEAD. | ||
| */ | ||
| #[allow(clippy::too_many_arguments)] |
Collaborator
There was a problem hiding this comment.
Suggested change
| #[allow(clippy::too_many_arguments)] |
I would rather not put these annotations throughout, especially for the more editorial style things like this.
|
|
||
| let pb = sys | ||
| .ssh_exec("svcs -Ho sta,nsta svc:/site/postboot:default")?; | ||
| let t = pb.out.trim().split_whitespace().collect::<Vec<_>>(); |
Collaborator
There was a problem hiding this comment.
Wow, that is absolutely not how I expect split_whitespace() to work! The fact that it ignores leading and trailing whitespace (and thus potentially misses empty columns!) is ... a choice.
| use crate::pipe::*; | ||
| use buildomat_common::OutputExt; | ||
|
|
||
| #[allow(clippy::wrong_self_convention)] |
Collaborator
There was a problem hiding this comment.
Suggested change
| #[allow(clippy::wrong_self_convention)] |
I would rather just ignore the editorial ones. I don't plan to have strict clippy cleanness block integration, etc.
| out.push(set); | ||
| std::fs::DirBuilder::new().mode(0o700).recursive(true).create(&out)?; | ||
| out.push(&format!("{}.json", file)); | ||
| out.push(format!("{}.json", file)); |
Collaborator
There was a problem hiding this comment.
Suggested change
| out.push(format!("{}.json", file)); | |
| out.push(format!("{file}.json")); |
| if let Some(branch) = cs.head_branch.as_deref() { | ||
| tb.env("GITHUB_BRANCH", branch); | ||
| tb.env("GITHUB_REF", &format!("refs/heads/{}", branch)); | ||
| tb.env("GITHUB_REF", format!("refs/heads/{}", branch)); |
Collaborator
There was a problem hiding this comment.
Suggested change
| tb.env("GITHUB_REF", format!("refs/heads/{}", branch)); | |
| tb.env("GITHUB_REF", format!("refs/heads/{branch}")); |
| error!(log, "worker liveness task error: {:?}", e); | ||
| } | ||
| } else if let Err(e) = worker_liveness_one(&log, &c).await { | ||
| error!(log, "worker liveness task error: {:?}", e); |
Collaborator
There was a problem hiding this comment.
Suggested change
| error!(log, "worker liveness task error: {:?}", e); | |
| error!(log, "worker liveness task error: {e:?}"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly mechanical fixes: removing needless borrows, adding lifetime annotations, using modern numeric constants (i32::MAX), and suppressing warnings for dropshot-generated dead code.
Notable equivalences: