Use min() for modal top position
#2583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
approved these changes
Nov 27, 2024
Contributor
charliepark
left a comment
charliepark
left a comment
There was a problem hiding this comment.
Shame about that merge conflict 😄🫠
New positioning looks good, though!
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 4, 2024
oxidecomputer/console@059c551...fd47bee * [fd47bee7](oxidecomputer/console@fd47bee7) tweak bump omicron script to prompt for message * [f6a3c06c](oxidecomputer/console@f6a3c06c) bump omicron for project-scoped oxql endpoint * [4d3a923c](oxidecomputer/console@4d3a923c) oxidecomputer/console#2596 * [576e1842](oxidecomputer/console@576e1842) oxidecomputer/console#2595 * [72b6d43d](oxidecomputer/console@72b6d43d) oxidecomputer/console#2579 * [15e55044](oxidecomputer/console@15e55044) oxidecomputer/console#2594 * [fa27caf9](oxidecomputer/console@fa27caf9) oxidecomputer/console#2588 * [aad054c5](oxidecomputer/console@aad054c5) oxidecomputer/console#2592 * [d97310be](oxidecomputer/console@d97310be) oxidecomputer/console#2593 * [8ba8a898](oxidecomputer/console@8ba8a898) oxidecomputer/console#2590 * [d7fd3c42](oxidecomputer/console@d7fd3c42) oxidecomputer/console#2586 * [23423c2b](oxidecomputer/console@23423c2b) oxidecomputer/console#2583
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 4, 2024
oxidecomputer/console@059c551...fd47bee * [fd47bee7](oxidecomputer/console@fd47bee7) tweak bump omicron script to prompt for message * [f6a3c06c](oxidecomputer/console@f6a3c06c) bump omicron for project-scoped oxql endpoint * [4d3a923c](oxidecomputer/console@4d3a923c) oxidecomputer/console#2596 * [576e1842](oxidecomputer/console@576e1842) oxidecomputer/console#2595 * [72b6d43d](oxidecomputer/console@72b6d43d) oxidecomputer/console#2579 * [15e55044](oxidecomputer/console@15e55044) oxidecomputer/console#2594 * [fa27caf9](oxidecomputer/console@fa27caf9) oxidecomputer/console#2588 * [aad054c5](oxidecomputer/console@aad054c5) oxidecomputer/console#2592 * [d97310be](oxidecomputer/console@d97310be) oxidecomputer/console#2593 * [8ba8a898](oxidecomputer/console@8ba8a898) oxidecomputer/console#2590 * [d7fd3c42](oxidecomputer/console@d7fd3c42) oxidecomputer/console#2586 * [23423c2b](oxidecomputer/console@23423c2b) oxidecomputer/console#2583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2523
Feels much more comfortable IMO.