Instance auto restart #2644
Merged
Instance auto restart #2644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
commented
Jan 9, 2025
benjaminleonard
commented
Jan 9, 2025
benjaminleonard
commented
Jan 9, 2025
benjaminleonard
commented
Jan 9, 2025
david-crespo
reviewed
Jan 9, 2025
hawkw
reviewed
Jan 9, 2025
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
This looks lovely! I'm not particularly qualified to review the implementation of the frontend code, but I left a couple very minor suggestions on the text we display in the UI. Thanks for all your work on getting this exposed in the console, it looks great!
Co-authored-by: Eliza Weisman <eliza@elizas.website>
1 task
david-crespo
force-pushed
the
instance-auto-restart
branch
from
99997ee to
e2a231d
Compare
hawkw
reviewed
Feb 7, 2025
Comment on lines
+102
to
+114
| // not all updates are restricted by state | ||
|
|
||
| // resize means changes to ncpus and memory | ||
| // https://github.com/oxidecomputer/omicron/blob/0c6ab099e/nexus/db-queries/src/db/datastore/instance.rs#L1282-L1288 | ||
| // https://github.com/oxidecomputer/omicron/blob/0c6ab099e/nexus/db-model/src/instance_state.rs#L39-L42 | ||
| resize: ['stopped', 'failed', 'creating'], | ||
|
|
||
| // https://github.com/oxidecomputer/omicron/blob/0c6ab099e/nexus/db-queries/src/db/datastore/instance.rs#L1209-L1215 | ||
| updateBootDisk: ['stopped', 'failed', 'creating'], | ||
|
|
||
| // there are no state restrictions on setting the auto restart policy, so we | ||
| // don't have a helper for it | ||
| // https://github.com/oxidecomputer/omicron/blob/0c6ab099e/nexus/db-queries/src/db/datastore/instance.rs#L1050-L1058 |
david-crespo
force-pushed
the
instance-auto-restart
branch
from
04bfec5 to
d707200
Compare
david-crespo
force-pushed
the
instance-auto-restart
branch
from
425524b to
7cde120
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 11, 2025
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2469
Fixes #2376
autoRestartEnabledto match actual API behaviourI'm sure someone will talk me down from the slow spinning icon when auto restart is enabled.