Audit log #2860
Draft
Audit log #2860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Can't repro locally, but this happened twice in CI so it's probably not a fluke. 
|
| import { toSyslogDateString, toSyslogTimeString } from '~/util/date' | ||
| import { docLinks } from '~/util/links' | ||
|
|
||
| export const handle = { crumb: 'Audit Log' } | ||
|
|
||
| // todo | ||
| // might want to still render the items in case of error |
There was a problem hiding this comment.
Probably, we could just add a banner and a refresh. What type of error could we expect here? If you were no longer authorised you'd be logged out? Just a general server error retrieving?
There was a problem hiding this comment.
Errors should be pretty unlikely if you can get to the page at all, so I’d say keep it very generic.
| return <div>Error State</div> | ||
| } | ||
|
|
||
| // todo |
There was a problem hiding this comment.
I think I'll do a skeleton state that is essentially a bunch of empty items to avoid too much layout shift when they load
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from #2849, which I accidentally merged and couldn't reopen even after I fixed
main.Still very rough, but has been a helpful exercise in working through some of the design due to the sheer amount of information and differing layout from other pages.
Stubbing out based on oxidecomputer/omicron#7339.
Uses Tanstack Virtual. On testing with > 500 lines without virtualisation it starts to get a bit chunky especially if you're interacting with the page (e.g. opening the row).
Hoping that silo name and actor display name can be plumbed through so those are hard-coded for now.
Still needs: