Remove arbitrary numeric keys from OxQL timeseries data #2890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I expected there to be type errors in the application code. Could you see why there aren't any? |
|
Ah, I think it's because we're using 
console/app/components/oxql-metrics/util.ts Line 132 in 41ed7e3 Line 50 in 41ed7e3 |
david-crespo
approved these changes
Aug 19, 2025
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 20, 2025
oxidecomputer/console@777a959...8cc5b25 * [8cc5b253](oxidecomputer/console@8cc5b253) oxidecomputer/console#2891 * [33b2b55c](oxidecomputer/console@33b2b55c) oxidecomputer/console#2890 * [41ed7e3a](oxidecomputer/console@41ed7e3a) oxidecomputer/console#2882 * [887a2cab](oxidecomputer/console@887a2cab) oxidecomputer/console#2870 * [76ca8cff](oxidecomputer/console@76ca8cff) oxidecomputer/console#2879
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 20, 2025
oxidecomputer/console@777a959...8cc5b25 * [8cc5b253](oxidecomputer/console@8cc5b253) oxidecomputer/console#2891 * [33b2b55c](oxidecomputer/console@33b2b55c) oxidecomputer/console#2890 * [41ed7e3a](oxidecomputer/console@41ed7e3a) oxidecomputer/console#2882 * [887a2cab](oxidecomputer/console@887a2cab) oxidecomputer/console#2870 * [76ca8cff](oxidecomputer/console@76ca8cff) oxidecomputer/console#2879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per oxidecomputer/omicron#8842, this updates the expected data shape for OxQL data in the web console.
Closes #2889