Bump serde_json from 1.0.143 to 1.0.145 #1428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.143 to 1.0.145. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.143...v1.0.145) --- updated-dependencies: - dependency-name: serde_json dependency-version: 1.0.145 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
ahl
reviewed
Sep 15, 2025
| | | ||
| 22 | _params: Query<QueryParams>, | ||
| | ^^^^^^^^^^^^^^^^^^ the trait `for<'de> serde::de::Deserialize<'de>` is not implemented for `QueryParams` | ||
| | ^^^^^^^^^^^^^^^^^^ the trait `for<'de> serde_core::de::Deserialize<'de>` is not implemented for `QueryParams` |
Collaborator
There was a problem hiding this comment.
@sunshowers @dtolnay is it kind of a bummer that we see serde_core:: rather than serde:: in error output now?
Contributor
There was a problem hiding this comment.
Yes, I flagged this in serde-rs/serde#2608 (comment). @oli-obk may be able to say whether this case is a compiler bug.
There was a problem hiding this comment.
Yea we shouldn't point to transitive dependencies if there is a direct dependency with the item in question reexported. The main message even gets this right, so I'll need to investigate whether the detailed message uses the full original path on purpose
Contributor
There was a problem hiding this comment.
The main message even gets this right
It probably doesn't, the main message is from serde-rs/serde#2963.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps serde_json from 1.0.143 to 1.0.145.
Release notes
Sourced from serde_json's releases.
Commits
efa66e3Release 1.0.14523679e2Add serde version constraintfc27bafRelease 1.0.144caef3c6Ignore uninlined_format_args pedantic clippy lint81ba3aaMerge pull request #1285 from dtolnay/serdecored21e8ceSwitch serde dependency to serde_core6beb6cdMerge pull request #1286 from dtolnay/up1dbc803Raise required compiler to Rust 1.610bf5d87Enforce trybuild >= 1.0.108d12e943Update actions/checkout@v4 -> v5Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)