Skip to content

Gzip response bodies #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Gzip response bodies #1448

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
23ca61d
gzip: failing test
david-crespo Jun 18, 2025
023c2fe
make the tests pass by implementing gzip
david-crespo Jun 19, 2025
814b37c
don't compress if transfer encoding chunked (bad)
david-crespo Jun 19, 2025
e274044
improve streaming detection and streaming test
david-crespo Oct 2, 2025
1c4173b
work on review comments, especially test coverage
david-crespo Oct 2, 2025
9c724c2
try async-compression like tower
david-crespo Oct 2, 2025
abc77de
address another round of review
david-crespo Oct 2, 2025
6f8ce41
one last review cycle: unit tests
david-crespo Oct 2, 2025
208aea5
tighten things up
david-crespo Oct 2, 2025
0836813
handle multiple quality values, make headers case-insensitive
david-crespo Oct 2, 2025
465fb21
couple more correctness things
david-crespo Oct 2, 2025
7ce0240
undo a couple of unnecessary changes
david-crespo Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 69 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions dropshot/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ categories = ["network-programming", "web-programming::http-server"]
workspace = true

[dependencies]
async-compression = { version = "0.4", features = ["tokio", "gzip"] }
async-stream = "0.3.6"
async-trait = "0.1.89"
base64 = "0.22.1"
Expand Down Expand Up @@ -77,6 +78,10 @@ features = [ "derive" ]
version = "1.47"
features = [ "full" ]

[dependencies.tokio-util]
version = "0.7"
features = [ "io", "compat" ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used for converting between AsyncRead/AsyncWrite from async-compression and the streams used by Body from hyper.

[dependencies.usdt]
version = "0.6.0"
optional = true
Expand All @@ -95,6 +100,7 @@ anyhow = "1.0.100"
async-channel = "2.5.0"
buf-list = "1.0.3"
expectorate = "1.2.0"
flate2 = "1.0"
hyper-rustls = "0.26.0"
hyper-staticfile = "0.10"
lazy_static = "1.5.0"
Expand Down
Loading
Loading