Skip to content

Conversation

aapoalas
Copy link
Contributor

@aapoalas aapoalas commented Nov 3, 2024

Removed more namespace imports, mostly trivial matters of no particular interest. (#1894 )

Two points of interest did appear, however:

  1. gimletlet/app-mgmt.toml is failing from exceeding the task stack size. I assume this is not important since CI is not failing, but I fixed it nonetheless.
  2. lpc55pins build auto-generates some imports, and in one case the generated import duplicates an existing import for the Direction enum. I avoided this by not importing it in the generated code and using the fully qualified name for that enum instead.

@aapoalas aapoalas marked this pull request as ready for review November 3, 2024 21:24
@aapoalas aapoalas changed the title chore: Remove star imports chore: Remove more namespace imports Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant