enable lldp to be aware of what switch it is managing #41
Conversation
|
|
||
| banner "Build" | ||
| cargo build --release | ||
| cargo build --release --verbose --features "dendrite" |
There was a problem hiding this comment.
Why are we enabling dendrite features on linux, when dendrite only runs on helios?
There was a problem hiding this comment.
The lldpd daemon is being added to the control plane test context in omicron#9533. The control plane test context runs dendrite stub on every OS. Currently, the logic in the control plane test context assumes that the startup command for each daemon will be the same on every OS, so adding the dendrite feature to the linux binary allows us to start them both with the same command as well as get the same behavior from them on both operating systems in the testing and development environment.
| mgs::detect_switch_slot(mgs_global, opts.mgs_addr).await | ||
| }); | ||
|
|
||
| let listen_addr = opts.listen_addr.unwrap_or(SocketAddr::new( |
There was a problem hiding this comment.
I think it's fine to add an IPv6 address, but I'd like to keep the IPv4. It looks like you've left lldpadm defaulting to IPv4 (https://github.com/oxidecomputer/lldp/blob/omicron-issue-8999/adm/src/main.rs#L422), so I don't know how it's managing to talk with lldpd.
There was a problem hiding this comment.
I think most OS configs will typically default localhost to ::1 on dual stack configured machines these days. This is true on all my various helios and linux machines.
ry@rydev:~$ ping -ns localhost
PING localhost (::1): 56 data bytes
64 bytes from ::1: icmp_seq=0. time=0.017 ms
64 bytes from ::1: icmp_seq=1. time=0.025 ms
This change is primarily a part of a larger effort to make the switch zone services location aware by having them communicate with their local MGS. This is also required to allow us to deploy some form of the daemon in our test context in omicron.
Related: