Conversation
andrewjstone
approved these changes
Nov 21, 2025
labbott
force-pushed
the
rotkh_check_fix
branch
from
ef2d6ab to
9acd9b8
Compare
Commit `f05c063e4b68926069efa0edb1159c8a2dbd9253` factored out some of the code for calculating the root key table hash but missed adding the final check against the CMPA. Bring it back.
labbott
force-pushed
the
rotkh_check_fix
branch
from
9acd9b8 to
b737280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
f05c063e4b68926069efa0edb1159c8a2dbd9253factored out some of the code for calculating the root key table hash but missed adding the final check against the CMPA. Bring it back.