Update the uuid kinds to emit a JSON Schema that includes the x-rust-type extension #5742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x-rust-type extension
sunshowers
reviewed
May 13, 2024
| default = ["std"] | ||
| serde = ["newtype-uuid/serde"] | ||
| schemars08 = ["newtype-uuid/schemars08", "schemars"] | ||
| schemars08 = ["newtype-uuid/schemars08", "dep:schemars", "dep:serde_json"] |
There was a problem hiding this comment.
Good catch re using dep:, missed that somehow.
Comment on lines
+23
to
+24
| #[cfg(feature = "schemars08")] | ||
| impl schemars::JsonSchema for [< $kind Kind >]{ |
There was a problem hiding this comment.
Yeah this is about what I expected -- let's chat today about seeing how we can get this into newtype-uuid instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this doesn't yet have a visible change, but I thought it would be useful to break things up into smaller pieces. This will have visible changes after oxidecomputer/newtype-uuid#47 and become useful after oxidecomputer/typify#584.