Use IdMaps for BlueprintPhysicalDisksConfig and BlueprintDatasetsConfig #7352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjstone
commented
Jan 15, 2025
jgallagher
approved these changes
Jan 15, 2025
| generation: Generation::new(), | ||
| disks: Vec::new(), | ||
| }); | ||
| .unwrap_or_else(|| BlueprintPhysicalDisksConfig::default()); |
Contributor
There was a problem hiding this comment.
Is it weird that BlueprintPhysicalDisksConfig impls Default but BlueprintDatasetsConfig doesn't? (Does BlueprintZonesConfig?)
I'm not sure whether I'd vote to add default to the ones missing it or remove it from the one(s?) that have it...
Contributor
Author
There was a problem hiding this comment.
I agree it's kinda weird, but I just went with what existed. I'm not sure which one to vote for either. I'd usually vote for getting rid of Default, but it sure seems handy here.
To avoid another CI lap I merged this in, but I'm happy to fix this in the follow up code I'm working on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.