Fix test_sled_instance_list#7367
Merged
jmpesp merged 2 commits intooxidecomputer:mainfrom Jan 17, 2025
Merged
Conversation
`test_sled_instance_list` was broken by the most recent change to the control plane test context: previously only one of the two sled agents (the first one) was provisionable for instances, and the test would check that one to test the sled instances list endpoint. The most recent change to the test context made all sled agents provisionable but didn't update the test to check all the sleds for the provisioned instance. This resulted in a test flake: if the instance was allocated to the first sled, it would pass. If it was allocated to the second sled, it would time out. Fixes oxidecomputer#7365
andrewjstone
approved these changes
Jan 16, 2025
Contributor
|
Thanks for the quick fix @jmpesp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_sled_instance_listwas broken by the most recent change to the control plane test context: previously only one of the two sled agents (the first one) was provisionable for instances, and the test would check that one to test the sled instances list endpoint. The most recent change to the test context made all sled agents provisionable but didn't update the test to check all the sleds for the provisioned instance. This resulted in a test flake: if the instance was allocated to the first sled, it would pass. If it was allocated to the second sled, it would time out.Fixes #7365