(3/5) [nexus] Add CRUD implementations for Affinity/Anti-Affinity Groups#7445
Merged
(3/5) [nexus] Add CRUD implementations for Affinity/Anti-Affinity Groups#7445
Conversation
44 tasks
hawkw
reviewed
Jan 31, 2025
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
Nothing too controversial here, and I like the large number of tests! I had a couple smallish thoughts I commented on.
andrewjstone
approved these changes
Jan 31, 2025
Contributor
andrewjstone
left a comment
andrewjstone
left a comment
There was a problem hiding this comment.
Looks great. Thanks for the comprehensive tests.
gjcolombo
approved these changes
Feb 3, 2025
hawkw
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #7076
Adds auth structures for Affinity/Anti-Affinity Groups, as well as datastore methods for implementing
CRUD (Create, Read, Update Delete) methods on these groups.