[reconfigurator] Replace todo!s with error returns#7552
Merged
jgallagher merged 1 commit intomainfrom Feb 18, 2025
Merged
Conversation
These were supposed to be fixed before merging #7495, but were not. Both of these are of the flavor "should never happen unless there's an internal bug" and could arguably be `debug_assert`s, but having the option for Nexus panics due to internal bugs here is not awesome.
davepacheco
approved these changes
Feb 18, 2025
hawkw
pushed a commit
that referenced
this pull request
Feb 21, 2025
These were supposed to be fixed before merging #7495, but were not. Both of these are of the flavor "should never happen unless there's an internal bug" and could arguably be `debug_assert`s, but having the option for Nexus panics due to internal bugs here is not awesome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were supposed to be fixed before merging #7495, but were not.
Both of these are of the flavor "should never happen unless there's an internal bug" and could arguably be
debug_asserts, but having the option for Nexus panics due to internal bugs here is not awesome.