wicket: Deny unknown fields when accepting RSS config TOML#7667
Merged
jgallagher merged 2 commits intomainfrom Feb 27, 2025
Merged
wicket: Deny unknown fields when accepting RSS config TOML#7667jgallagher merged 2 commits intomainfrom
jgallagher merged 2 commits intomainfrom
Conversation
leftwo
approved these changes
Feb 27, 2025
Contributor
|
Any chance we could test this on an a4x2 setup, just to be sure we don't break something there? |
Contributor
Author
|
I can give that a whirl before merging, sure, but I don't think a4x2 does (or maybe even can?) use wicket to run RSS. |
Contributor
Oh yeah, this is all deep in wicket. Feel free to ignore that request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From discussions on #7653: wicket does not and should not accept a
[recovery_silo]section in the uploaded TOML, but on main it will silently discard it. This PR turns onserde(deny_unknown_fields); now, attempting to upload a config TOML with an unexpected section will fail: