Closed
Conversation
jgallagher
commented
Mar 6, 2025
| # building `ddm-admin-client` (which will instruct you to update | ||
| # `tools/maghemite_openapi_version`). | ||
| source.commit = "93cd0d642cf1b58f9f4528275e2a2aa758e9feb3" | ||
| source.commit = "8da5bd1c4e41c9b5cc2513eec443e7d761c9f5e5" |
Contributor
Author
There was a problem hiding this comment.
I think this commit should have been in sync with the other two later in the file, so I updated all three to point to the latest main. (@sunshowers please correct me if I'm wrong - it looks like they diverged on #7516?)
Contributor
There was a problem hiding this comment.
So uh, to be honest, I tried getting to all of them but completely missed this...
I feel like we should have one place to define versions and hashes if at all possible. Maybe in a different section in this file, or in another file.
Contributor
Author
|
closing in favor of #7754 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.