update most code to rand 0.9 #8828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
1 task
| @@ -129,7 +129,7 @@ pub fn create_pkgs( | |||
| let shares = rack_secret.split(threshold, total_shares)?; | |||
| let share_digests = share_digests(&shares); | |||
| let mut salt = [0u8; 32]; | |||
| OsRng.fill_bytes(&mut salt); | |||
| OsRng.try_fill_bytes(&mut salt).expect("fetched random bytes"); | |||
There was a problem hiding this comment.
This is fine, but I'm curious why you changed it.
There was a problem hiding this comment.
rand 0.9 no longer has OsRng be infallible (previously it would panic internally, now the error is bubbled up so we get to panic lmao)
There was a problem hiding this comment.
Ok, and you wanted to make 0.8 work the same as 0.9 in the codebase. And the failure mode seems better. Thanks!
| RackSecret { | ||
| secret: SecretBox::new(Box::new(Scalar::random(&mut rng))), | ||
| secret: SecretBox::new(Box::new( | ||
| Scalar::from_bytes_mod_order_wide(&scalar_bytes), |
There was a problem hiding this comment.
Same here. Why the change if we are using the same rand version (0.8.5) ?
There was a problem hiding this comment.
I was trying to switch this over to rand 0.9 but unfortunately failed, haha. Reverted this change.
Created using spr 1.3.6-beta.1
andrewjstone
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, almost all code now uses rand 0.9. The only exception is the bootstore which uses vsss-rs (and which I believe will be going away at some point).