Skip to content

[nexus] re-enable sp_ereport_ingester post-R16 #8838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[nexus] re-enable sp_ereport_ingester post-R16 #8838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions smf/nexus/multi-sled/config-partial.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ read_only_region_replacement_start.period_secs = 30
alert_dispatcher.period_secs = 60
webhook_deliverator.period_secs = 60
sp_ereport_ingester.period_secs = 30
# Disabled in R16, as the Hubris task that handles ereport ingestion requests
# has not merged yet, and trying to ingest them will just result in Nexus
# logging a bunch of errors.
sp_ereport_ingester.disable = true

[default_region_allocation_strategy]
# by default, allocate across 3 distinct sleds
Expand Down
4 changes: 0 additions & 4 deletions smf/nexus/single-sled/config-partial.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ read_only_region_replacement_start.period_secs = 30
alert_dispatcher.period_secs = 60
webhook_deliverator.period_secs = 60
sp_ereport_ingester.period_secs = 30
# Disabled in R16, as the Hubris task that handles ereport ingestion requests
# has not merged yet, and trying to ingest them will just result in Nexus
# logging a bunch of errors.
sp_ereport_ingester.disable = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove the disable field from the corresponding Rust struct?


[default_region_allocation_strategy]
# by default, allocate without requirement for distinct sleds.
Expand Down
Loading