[SCIM 3/4]: SCIM client token CRUD + Bearer auth #9180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the CRUD routines for the tokens that will be used to authenticate SCIM clients for SamlScim Silos. Also implement the Bearer based authentication for SCIM clients. Fill in the skeleton of CrdbScimProviderStore, which when implemented will complete the SCIM implementation in Nexus.
| authz_silo: &authz::Silo, | ||
| id: Uuid, | ||
| ) -> LookupResult<Option<ScimClientBearerToken>> { | ||
| opctx.authorize(authz::Action::ListChildren, authz_silo).await?; |
There was a problem hiding this comment.
I'm thinking you should check the read permission on a value of type authz::ScimClientBearerToken instead, right?
There was a problem hiding this comment.
agreed, my bad - done in ed37a89
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
|
||
| //! scim2-rs uses the patterm of implementing a SCIM "provider" over something |
| nexus_id | ||
| ); | ||
|
|
||
| CREATE TABLE IF NOT EXISTS omicron.public.scim_client_bearer_token ( |
There was a problem hiding this comment.
I think I would rather call this (and the authz resource) scim_client_token. It contains a bearer token, but the Token concept is really the whole row.
Instead of silo Also grant silo admin role to USER_TEST_PRIVILEGED.id() instead of OpContext::for_tests in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the CRUD routines for the tokens that will be used to authenticate SCIM clients for SamlScim Silos. Also implement the Bearer based authentication for SCIM clients.
Fill in the skeleton of CrdbScimProviderStore, which when implemented will complete the SCIM implementation in Nexus.