Skip to content

clickhouse: prevent replicated tables from starting in read-only mode. #9183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

clickhouse: prevent replicated tables from starting in read-only mode. #9183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion clickhouse-admin/types/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,13 @@ impl ReplicaConfig {
<max_tasks_in_queue>1000</max_tasks_in_queue>
</distributed_ddl>
<!-- Disable sparse column serialization, which we expect to not need -->
<merge_tree>
<!-- Disable sparse column serialization, which we expect to not need -->
<ratio_of_defaults_for_sparse_serialization>1.0</ratio_of_defaults_for_sparse_serialization>
<!-- Prevent ClickHouse from setting distributed tables to read-only. -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc nit, this is setting the local replica to read-only. I.e., it avoids updating the local state with the shared state in the Raft cluster.

<!-- See https://github.com/oxidecomputer/omicron/issues/8595 for details. -->
<replicated_max_ratio_of_wrong_parts>1.0</replicated_max_ratio_of_wrong_parts>
</merge_tree>
{macros}
{remote_servers}
Expand Down
Loading