Make UnstableReconfiguratorState::target_blueprint non-optional
#9423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
approved these changes
Nov 20, 2025
Base automatically changed from
john/blueprint-builder-no-planning-input
to
main
November 21, 2025 16:40
`UnstableReconfiguratorState`s constructed from real systems always supplied a target blueprint, because real systems are required to always have one. We'd kept this as optional to allow for `reconfigurator-cli`'s simulated system to not have a blueprint at all, but I'd like to make other changes related to the `PlanningInput` that trip over this difference. This PR addresses the simulator side by having it claim to have a blueprint with the nil ID and containing nothing any time it's asked for the current list of blueprints or current target blueprint and one hasn't otherwise been set (i.e., by loading an example system or an existing serialized state).
jgallagher
force-pushed
the
john/unstable-state-always-has-a-target
branch
from
00f12bb to
4866fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnstableReconfiguratorStates constructed from real systems always supplied a target blueprint, because real systems are required to always have one. We'd kept this as optional to allow forreconfigurator-cli's simulated system to not have a blueprint at all, but I'd like to make other changes related to thePlanningInputthat trip over this difference.This PR addresses the simulator side by having it claim to have a blueprint with the nil ID and containing nothing any time it's asked for the current list of blueprints or current target blueprint and one hasn't otherwise been set (i.e., by loading an example system or an existing serialized state).
(Staged on top of #9417)