-
Notifications
You must be signed in to change notification settings - Fork 63
Update to latest MGS #9443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to latest MGS #9443
Conversation
| checksum = "117725a109d387c937a1533ce01b450cbde6b88abceea8473c4d7a85853cda3c" | ||
| dependencies = [ | ||
| "lazy_static", | ||
| "windows-sys 0.59.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a downgrade, is that what we want? I had to manually fix this up last time too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what's happening with these. It shows up if I do this on main:
omicron (main %=)]% cargo update -p [email protected]
Updating crates.io index
Locking 1 package to latest Rust 1.89.0 compatible version
Updating socket2 v0.6.0 -> v0.6.1
Maybe related to the "Locking 1 package to latest Rust 1.89.0 compatible version"?
I'm tempted to say "this is a windows crate which is totally irrelevant, so it's probably not worth doing work to worry about it and it's fine to let cargo update do whatever it does". But it would be nice to understand..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is rust-lang/cargo#5529. I can either manually patch this up, or just leave it alone (my preference since this is a crate we don't use in practice).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with leaving it alone if others are comfortable, especially since the downgrades are things we don't care about
| checksum = "4979f22fdb869068da03c9f7528f8297c6fd2606bc3a4affe42e6a823fdb8da4" | ||
| dependencies = [ | ||
| "cfg-if", | ||
| "windows-targets 0.52.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another downgrade
labbott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might submit a tufaceous PR sometime just to bring everything to the same hubtools version
This isn't totally risk-free - it also pulls in a bump to tokio. But I think in general we want to track the latest tokio anyway?
Primary motivator for this is to pick up oxidecomputer/management-gateway-service#472, since @askfongjojo had a failed mupdate yesterday that should be fixed by that.