separate some of nexus-test-utils into modules #9445
Draft
+2,296
−2,289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is ready for review, but I'm leaving it "draft" to keep me from merging it before #9444 has landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nexus/test-utils/src/lib.rshas become a bit of a dumping ground for test-related helpers. This PR separates two big pieces into separate Rust modules (still in the same package, and exposed in the same way to consumers):starter.rsholds the implementation of theControlPlaneStarterandnexus_test.rsholds theControlPlaneTestContextand its constructor functions.The changes here should just be code movement and associated things like import changes.
Staged on top of #9444.