Skip to content

Wire up public API for external subnet CRUD#9762

Merged
bnaecker merged 2 commits intomainfrom
wire-up-external-subnet-crud-api
Jan 31, 2026
Merged

Wire up public API for external subnet CRUD#9762
bnaecker merged 2 commits intomainfrom
wire-up-external-subnet-crud-api

Conversation

@bnaecker
Copy link
Collaborator

  • Connect API endpoint handlers with existing database methods
  • Add methods for listing external subnets
  • Add integration tests

@bnaecker
Copy link
Collaborator Author

Stacked on #9754

Copy link
Contributor

@mergeconflict mergeconflict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from wire-up-subnet-pool-silo-api to main January 31, 2026 01:35
@bnaecker
Copy link
Collaborator Author

Thanks @mergeconflict! I've taken your suggestion and have conflicts with main fixed up, but we'll still run into the clippy lint fixed by #9763. I'm going to wait for that to go back first, and then rebase again. I'd rather not clog up the CI queue with something we know will not pass.

@david-crespo
Copy link
Contributor

I didn’t check too closely, but I didn’t see any issues in the parts I did read.

- Connect API endpoint handlers with existing database methods
- Add methods for listing external subnets
- Add integration tests
@bnaecker bnaecker force-pushed the wire-up-external-subnet-crud-api branch from 4de6963 to ce854b4 Compare January 31, 2026 04:06
@bnaecker bnaecker enabled auto-merge (squash) January 31, 2026 04:06
@bnaecker bnaecker merged commit 17cf00d into main Jan 31, 2026
16 checks passed
@bnaecker bnaecker deleted the wire-up-external-subnet-crud-api branch January 31, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants