Skip to content

new fn try_instance_simulate should be behind the multicast gate #9763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nieuwejaar merged 1 commit into from
Jan 31, 2026
Merged

new fn try_instance_simulate should be behind the multicast gate #9763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nexus/tests/integration_tests/instances.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9006,6 +9006,9 @@ pub async fn instance_simulate(nexus: &Arc<Nexus>, id: &InstanceUuid) {
///
/// Returns an error instead of panicking if the sled agent communication fails.
/// This is useful during test cleanup where the sled agent may be unavailable.
// This is currently only consumed by tests behind the multicast feature gate.
// If/when it has another consumer, this cfg can be removed.
#[cfg(feature = "multicast")]
pub async fn try_instance_simulate(
Copy link
Collaborator

@zeeshanlakhani zeeshanlakhani Jan 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nieuwejaar apologies, as I had finally had review on the other work (and it came in before). Minor, but, should we just make this #[allow(dead_code)] as it's a general function.

Copy link
Collaborator

@zeeshanlakhani zeeshanlakhani Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, minor either way.

nexus: &Arc<Nexus>,
id: &InstanceUuid,
Expand Down
Loading