expose time_created and time_modified on User and Group API types#9958
Open
charliepark wants to merge 7 commits intomainfrom
Open
expose time_created and time_modified on User and Group API types#9958charliepark wants to merge 7 commits intomainfrom
charliepark wants to merge 7 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated approach to #9494, using the new nexus-types-versions versioning system
lol
#9494:
#9958:
———
One of the comments in oxidecomputer/console#2887 noted that returning the time_modified for silo_users and silo_groups would be helpful.
Angela notes: "SCIM enables the IdP to update a user or group record whenever there is a change. It's not complete update history like audit log entries but will allow the operator to quickly tell if a change made in IdP has reached Oxide at all."
Those fields are already in the database; this PR just adds them to the endpoints.