Open
Conversation
Created using spr 1.3.6-beta.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote
serde_human_bytesa long time ago and it's ended up in use in Omicron in several spots. I've released it asbyte-wrapperon crates.io (repository), with a few changes:serde(with)supportThe schemas specified by byte-wrapper are equivalent, but represented differently/more programmatically than our existing schemas. If we used
byte-wrapper's schemas, drift would detect incompatible changes to old Sled Agent API versions. In the interest of not trying to introduce a new version of the Sled Agent API unnecessarily, I've opted to preserve the old schema instead, and left a note that if and when the type changes, the new schema should be used.This is a ticking time bomb -- tufaceous depends on serde_human_bytes main, and the omicron-common job generates a fresh lockfile. A breaking change to serde_human_bytes main (a reasonable thing to do) caused the omicron-common job to fail. I've put serde_human_bytes back to an old revision until we fix tufaceous (which we can do along with/after tufaceous v2).