Skip to content

Conversation

@danieleades
Copy link

@danieleades
Copy link
Author

@ahl i'm not sure this is actually testing what i'd hoped to test. would be good to get your eyes on it.

for example i haven't patched progenitor-client, which is probably an issue

@ahl
Copy link
Collaborator

ahl commented Jan 4, 2026

Nope! You'll have to run cargo xtask generate

@danieleades
Copy link
Author

Nope! You'll have to run cargo xtask generate

I did run that locally- didn't see any changes. Which was surprising

@danieleades
Copy link
Author

@ahl i'm still not seeing any changes to code generation when running cargo xtask generate

daniel.eades added 2 commits January 5, 2026 08:57
@danieleades
Copy link
Author

danieleades commented Jan 5, 2026

got it. had to explicitly patch typify as well.

as you can see the changes are fairly minimal, and they make the cloning explicit rather than implicit (as well as removing a couple of thousand lines of code)

@ahl ahl mentioned this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants