Indicator should allow stopping instances at Init #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lifecycle::Indicator` to date is only used for the virtio NIC, but `phd-tests` doesn't actually exercise that.. so, add an `Indicator` to `I440FxHostBrdige` as it is a component present at all times in all VMs, and glue it into Lifecycle as expected in any other application of Indicator. With this, the new test to stop a created-but-not-started VM hangs and eventually fails with a timeout, and fixing the expected state transition in Indicator makes it pass. Incidentally, this exercises the rest of the state transitions, with various tests pausing or restarting VMs, migrating them, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lifecycle::Indicatorto date is only used for the virtio NIC, butphd-testsdoesn't actually exercise that.. so, add anIndicatortoI440FxHostBrdigeas it is a component present at all times in all VMs, and glue it into Lifecycle as expected in any other application of Indicator.With this, the new test to stop a created-but-not-started VM hangs and eventually fails with a timeout, and fixing the expected state transition in Indicator makes it pass. Incidentally, this exercises the rest of the state transitions, with various tests pausing or restarting VMs, migrating them, etc.
I'd pushed the patch and neglected to click the PR button :( this fixes #994.