Add DTrace script to monitor viona activity #1009
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citrus-it
force-pushed
the
andy/viona.d
branch
from
4a236a1 to
75373e0
Compare
citrus-it
force-pushed
the
andy/viona.d
branch
from
75373e0 to
36c0c19
Compare
dancrossnyc
approved these changes
Jan 8, 2026
Contributor
dancrossnyc
left a comment
dancrossnyc
left a comment
There was a problem hiding this comment.
We've been using this quite a bit for some time to debug the multiqueue implementation as we've been developing it. It's been very valuable, and works well.
iximeow
approved these changes
Jan 9, 2026
Member
iximeow
left a comment
iximeow
left a comment
There was a problem hiding this comment.
nice! noticed a few things, but clearly this is useful as-is.
| } | ||
|
|
||
| viona_ioctl:entry/arg1 == VNA_IOC_GET_FEATURES/ { | ||
| self->pending = arg1;; |
Member
There was a problem hiding this comment.
Suggested change
| self->pending = arg1;; | |
| self->pending = arg1; |
Comment on lines
+145
to
+151
| viona_ioctl:return/self->pending == VNA_IOC_INTR_POLL_MQ/ { | ||
| self->pending = 0; | ||
| intrp = (vioc_intr_poll_mq_t *)copyin(self->dptr, | ||
| sizeof (vioc_intr_poll_mq_t)); | ||
| printf("INTR_POLL %x set (0x%08x)\n", *self->rvp, | ||
| intrp->vipm_status[0]); | ||
| } |
Member
There was a problem hiding this comment.
is the return code for VNA_IOC_INTR_POLL_MQ interesting? we've not set self->cmd so the blanket viona_ioctl/self->cmd && arg1/ at the bottom wouldn't say anything.
Comment on lines
+246
to
+249
| viona_ioctl:return/self->cmd != 0 && arg1 != 0/ { | ||
| printf("ioctl(%s) returning 0x%x\n", self->cmd, arg1); | ||
| self->cmd = 0; | ||
| } |
Member
There was a problem hiding this comment.
might be interesting to print errno if arg1 == -1 yeah? presumably you have not had to care about that in working on multiqueue :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.