Skip to content

fix new 1.81.0 warning and clippy error #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2024
Merged

fix new 1.81.0 warning and clippy error #760

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b805af
fix new 1.81.0 warning and clippy error
iximeow Sep 6, 2024
6e02d1d
the unused pub(crate) struct warnings are new also, allow these cases
iximeow Sep 6, 2024
98ef716
inspect_err is a new one to me! really don't like this clippy lint
iximeow Sep 6, 2024
2f1a483
fix copypaste in comment
iximeow Sep 6, 2024
7e80d6e
try a different shade of paint
iximeow Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/propolis-cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ async fn migrate_instance(
.collect::<Result<Vec<_>, _>>()?
// Then any errors from polling the source/destination
.into_iter()
.collect::<anyhow::Result<_>>()?;
.collect::<anyhow::Result<()>>()?;

Ok(())
}
Expand Down
4 changes: 4 additions & 0 deletions lib/propolis/src/firmware/smbios/bits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,11 @@ pub(crate) struct Type1 {
}
raw_table_impl!(Type1, 1);

// We don't create type 2 tables yet, but it's nice to have the definition on hand.
/// Type 2 (Baseboard Information)
#[derive(Copy, Clone)]
#[repr(C, packed)]
#[allow(dead_code)]
pub(crate) struct Type2 {
pub header: StructureHeader,
pub manufacturer: u8,
Expand All @@ -159,9 +161,11 @@ pub(crate) struct Type2 {
}
raw_table_impl!(Type2, 2);

// We don't create type 2 tables yet, but it's nice to have the definition on hand.
/// Type 3 (System Enclosure) - Version 2.7
#[derive(Copy, Clone)]
#[repr(C, packed)]
#[allow(dead_code)]
pub(crate) struct Type3 {
pub header: StructureHeader,
pub manufacturer: u8,
Expand Down
Loading