preserve requested formatting in some Display impls#22
Merged
sunshowers merged 1 commit intomainfrom Apr 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm writing some tooling with this and noticed that when I formatted
ArtifactVersionandArtifactKindinto fixed-width fields, the width wasn't being honored. I guess this is the way you're supposed to delegateDisplay? Here's a playground that shows the problem outside of tufaceous:https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=80fe4b1d5e37fb96f2abd500722bc36a
There are other impls in tufaceous that I didn't fix because they weren't in my way and it was not obvious how best to do it.