Conversation
labbott
force-pushed
the
measurement_corpus_take_2
branch
2 times, most recently
from
c428098 to
7dcff86
Compare
sunshowers
approved these changes
Sep 3, 2025
| ); | ||
| } | ||
| KnownArtifactKind::MeasurementCorpus => { | ||
| return make_filler_text( |
Contributor
There was a problem hiding this comment.
Do you plan to add some structure here in the future, similar to say the Hubris artifacts?
Collaborator
Author
There was a problem hiding this comment.
I probably should. We already do this for sprockets testing (we use https://github.com/oxidecomputer/dice-util/tree/main/attest-mock)
This will be use with sprockets and delivered as part of the installinator document
labbott
force-pushed
the
measurement_corpus_take_2
branch
from
7dcff86 to
d5ef2b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be use with sprockets and delivered as part of the installinator document