Add Ruby 3.4 as a supported version#474
Merged
ianks merged 1 commit intooxidize-rb:mainfrom Dec 28, 2024
Merged
Conversation
f6c02dd to
4a981cb
Compare
f839a10 to
d983667
Compare
stanhu
commented
Dec 28, 2024
.github/workflows/ci.yml
Outdated
| matrix: | ||
| # Test against all versions supported by rubygems | ||
| ruby_version: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4.0-preview2"] | ||
| ruby_version: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4"] |
Contributor
Author
There was a problem hiding this comment.
It seems https://github.com/oxidize-rb/rb-sys/pull/472/files already handles this, so I'll pull this commit.
d983667 to
09a8810
Compare
Collaborator
|
thank you! |
Contributor
Author
|
@ianks Thanks for the quick merge! I'm having trouble using Does UPDATE: The compile works if I point to [build-dependencies]
rb-sys-env = { git = "https://github.com/oxidize-rb/rb-sys.git", branch = "main" } |
Collaborator
|
I pushed a new version of rb-sys-env recently, it should have these changes: https://crates.io/crates/rb-sys-env/0.2.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also test Ruby 3.4.x in CI.