Revert "Make it possible to override RUBY_TARGET (#512)"#514
Closed
stanhu wants to merge 2 commits intooxidize-rb:mainfrom
Closed
Revert "Make it possible to override RUBY_TARGET (#512)"#514stanhu wants to merge 2 commits intooxidize-rb:mainfrom
stanhu wants to merge 2 commits intooxidize-rb:mainfrom
Conversation
This reverts commit 7b03755.
Contributor
Author
|
Oops, the revert is not complete. |
…)" This reverts commit 798fad1.
Contributor
Author
|
Closing in favor of #513. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
RUBY_TARGETneeds to be a static value right now because of the way the Docker images are set up. This change broke the Docker images, so let's revert.This reverts commit 7b03755.