New features for rb-sys-test-helpers 0.3.0 #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panics inside protect() were trying to unwind through an extern "C" FFI boundary, causing undefined behavior and process abort with no readable output. Added catch_unwind inside ffi_closure to catch panics before they cross the FFI boundary, then re-throw them after rb_protect returns. This ensures panics are properly propagated with readable error messages instead of causing silent process aborts.
This allows RubyException to be used with the ? operator and converted to Box<dyn Error>, making it more ergonomic to use in Result-returning functions.
Tests can now return Result<(), E> and use the ? operator for more ergonomic error handling. The macro detects Result return types and properly propagates both Ruby exceptions and Rust errors.
Changed the check to also support "full" in addition to "1" for displaying Ruby exception backtraces.
Added a new public struct that enables GC stress mode and restores the previous value when dropped. Refactored with_gc_stress to use it, ensuring GC stress is properly restored even when panics occur.
Bumped both rb-sys-test-helpers and rb-sys-test-helpers-macros from 0.2.2 to 0.3.0 to reflect the new features and breaking changes.
Removed the shellHook that automatically exec'd zsh, allowing users to use their preferred shell.
ianks
force-pushed
the
test-helpers-0.3.0
branch
from
7625fcb to
5520111
Compare
ianks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix undefined behavior in
protect(): Panics insideprotect()were trying to unwind through anextern "C"FFI boundary, causing process abort with no readable output. Addedcatch_unwindto catch panics before they cross the FFI boundary, then re-throw them afterrb_protectreturns.Ergonomic improvements for test helpers:
DisplayandErrortraits forRubyException, allowing use with?operator#[ruby_test]macro so tests can returnResult<(), E>GcStressGuardfor RAII-style scoped GC stress testingRUST_BACKTRACEcheck to support"full"in addition to"1"Breaking Changes
Version bumped from 0.2.2 to 0.3.0 due to API additions and behavioral changes.