feat(stable-api): add RB_ID2SYM and RB_SYM2ID for symbol conversion #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements #669 - Add id2sym to StableApiDefinition for ID2SYM/RB_ID2SYM - Add sym2id to StableApiDefinition for SYM2ID/RB_SYM2ID - Handle both static symbols (tagged pointers) and dynamic symbols - Implement for Ruby 2.7, 3.0, 3.1, 3.2, 3.3, 3.4, 4.0 - Add C fallbacks in compiled.c using ID2SYM and SYM2ID macros - Add FFI wrappers in compiled.rs - Add public macro wrappers (ID2SYM, SYM2ID, RB_ID2SYM, RB_SYM2ID) - Add comprehensive parity tests and functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Batch 7 of the stable API implementation plan - Adds Symbol/ID conversion methods to the Stable API:
RB_ID2SYM- Convert ID to SymbolRB_SYM2ID- Convert Symbol to IDThese methods handle both static symbols (tagged pointers) and dynamic symbols (heap-allocated).
Changes
id2sym()andsym2id()methods toStableApiDefinitiontrait(id << 8) | 0x0cid2symis safe (just bit manipulation)sym2idis unsafe (may access heap for dynamic symbols)compiled.cand Rust wrapper incompiled.rsRB_ID2SYMandRB_SYM2IDmacro wrappers inmacros.rsstable_api_test.rsTesting
All tests pass successfully ✅
Related Issues
Checklist