Skip to content

fix: consistent macOS deployment target for Metal compatibility #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicholasjpaterno wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: consistent macOS deployment target for Metal compatibility #320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af169d7
fix: consistent macOS deployment target for Metal compatibility
nicholasjpaterno Feb 21, 2026
c6191a9
refactor: extract resolve_deployment_target helper, add set_var safet…
nicholasjpaterno Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions mlx-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ fn find_clang_rt_path() -> Option<String> {
None
}

/// Resolve the macOS deployment target.
///
/// Uses `MACOSX_DEPLOYMENT_TARGET` env var if set, otherwise defaults to 14.0
/// (MLX's minimum supported version for Metal).
#[cfg(target_os = "macos")]
fn resolve_deployment_target() -> String {
env::var("MACOSX_DEPLOYMENT_TARGET").unwrap_or_else(|_| "14.0".to_string())
}

fn build_and_link_mlx_c() {
let mut config = Config::new("src/mlx-c");
config.very_verbose(true);
Expand All @@ -53,6 +62,19 @@ fn build_and_link_mlx_c() {
config.define("CMAKE_C_COMPILER", "/usr/bin/cc");
config.define("CMAKE_CXX_COMPILER", "/usr/bin/c++");

// Set macOS deployment target for Metal/MLX compatibility
// This avoids linking errors with ___isPlatformVersionAtLeast
// See: https://github.com/ml-explore/mlx/issues/1602
#[cfg(target_os = "macos")]
{
let deployment_target = resolve_deployment_target();
config.define("CMAKE_OSX_DEPLOYMENT_TARGET", &deployment_target);
// Ensure environment is set for compiler-rt symbols
// SAFETY: build scripts are single-threaded
unsafe { std::env::set_var("MACOSX_DEPLOYMENT_TARGET", &deployment_target) };
println!("cargo:rerun-if-env-changed=MACOSX_DEPLOYMENT_TARGET");
}

#[cfg(debug_assertions)]
{
config.define("CMAKE_BUILD_TYPE", "Debug");
Expand Down Expand Up @@ -97,6 +119,17 @@ fn build_and_link_mlx_c() {
println!("cargo:rustc-link-lib=framework=Accelerate");
}

// Set minimum macOS version for linker to match compiled objects
// Must match CMAKE_OSX_DEPLOYMENT_TARGET to avoid ___isPlatformVersionAtLeast errors
#[cfg(target_os = "macos")]
{
let deployment_target = resolve_deployment_target();
println!(
"cargo:rustc-link-arg=-mmacosx-version-min={}",
deployment_target
);
}

// Link against Xcode's clang runtime for ___isPlatformVersionAtLeast symbol
// This is needed on macOS 26+ where the bundled LLVM runtime may be outdated
// See: https://github.com/conda-forge/llvmdev-feedstock/issues/244
Expand Down
Loading