Merged
Conversation
Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
Owner
|
@copilot see if any functions can be reused from the wider code library, i.e. actualVaporPressure exists in humidity.ts for actual vapor pressure? |
Copilot
AI
changed the title
[WIP] Implement PET thermal comfort index in PET.ts
Implement PET thermal comfort index
Oct 28, 2025
Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
Contributor
Author
Refactored to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Successfully implemented the PET (Physiological Equivalent Temperature) thermal comfort index with:
Implementation
Latest Update
Refactored to use
actualVaporPressure()fromhumidity.tsinstead of duplicating the calculation logic inline, improving code reuse and maintainability.Features
Testing
Security
The implementation follows all project conventions including using Kelvin for all temperatures and maintaining consistency with existing thermal comfort indices.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.