Add altitude calculation from pressure time series#37
Conversation
Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
|
@copilot Use the Reading class in common.cs |
…g interface Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
|
@copilot See if any formulas can be reused, i.e. altitudeFromPressureDifference - could it already exist in Temperature.ts or Pressure.ts? |
Reviewed
The Would you prefer I move this function to |
|
@copilot move sort logic to common.cs |
Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
|
@copilot rename sortReadingsByTimestamp to sortOldestToNewest |
Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
|
@copilot Reomve the pressureSeries logic |
Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
|
@copilot undo changes to filterReadingsByTimeRange |
Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
|
@copilot Could pressureAltitude in pressure.ts be used? Could the barometric formula be used? (it's in pressure.ts). |
Analyzed both options:
The key advantage of the current
Should I simplify by using |
altitudeFromPressureDifference()function inaltitude.tsImplement(removed per reviewer feedback)calculateAltitudesFromPressureSeries()function for time series dataUse(reverted per reviewer feedback)sortOldestToNewest()in temperature.tssortOldestToNewest()utility function incommon.tsOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.