Skip to content

OZ-331: Add a validation step for minimum docker compose version #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kipchubett merged 2 commits into from
Jan 28, 2025
Merged

OZ-331: Add a validation step for minimum docker compose version #140

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2f7312
OZ-331: Add a validation step for minimum docker compose version
kdaud Jan 27, 2025
e786f18
apply suggestion
kdaud Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions scripts/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,15 @@ fi
INSTALLED_DOCKER_VERSION=$(docker version -f "{{.Server.Version}}")
MINIMUM_REQUIRED_DOCKER_VERSION_REGEX="^((([2-9][1-9]|[3-9][0]|[0-9]{3,}).*)|(20\.([0-9]{3,}|[1-9][1-9]|[2-9][0]).*)|(20\.10\.([0-9]{3,}|[2-9][0-9]|[1][3-9])))"
if [[ $INSTALLED_DOCKER_VERSION =~ $MINIMUM_REQUIRED_DOCKER_VERSION_REGEX ]]; then
if command -v gp version &> /dev/null; then
export GITPOD_ENV="true"
export USE_HTTPS="true"
else
export GITPOD_ENV="false"
fi
INSTALLED_DOCKER_COMPOSE_VERSION=$(docker compose version --short 2>/dev/null)
MINIMUM_REQUIRED_DOCKER_COMPOSE_VERSION_REGEX="^([2-9]|[1-9][0-9]+)\.*"
if [[ $INSTALLED_DOCKER_COMPOSE_VERSION =~ $MINIMUM_REQUIRED_DOCKER_COMPOSE_VERSION_REGEX ]]; then
if command -v gp version &> /dev/null; then
export GITPOD_ENV="true"
export USE_HTTPS="true"
else
export GITPOD_ENV="false"
fi

# Export the scheme
exportScheme
Expand Down Expand Up @@ -96,6 +99,7 @@ if [[ $INSTALLED_DOCKER_VERSION =~ $MINIMUM_REQUIRED_DOCKER_VERSION_REGEX ]]; th
fi

else
echo "$ERROR Docker compose versions < 2.x are not supported"
echo "$ERROR Docker versions < 20.10.13 are not supported"
fi
Comment on lines 101 to 106
Copy link
Contributor

@kipchubett kipchubett Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should be under different "else" statements.


Expand Down
Loading