Remove regexps in join_template plugin#731
Merged
goshansmails merged 29 commits intomasterfrom Feb 6, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 72.28% 73.70% +1.42%
==========================================
Files 137 145 +8
Lines 13985 15347 +1362
==========================================
+ Hits 10109 11312 +1203
- Misses 3311 3412 +101
- Partials 565 623 +58 ☔ View full report in Codecov by Sentry. |
HeadHunter483
approved these changes
Jan 15, 2025
7f21c37 to
c1f78d1
Compare
c1f78d1 to
d951d39
Compare
kirillov6
approved these changes
Feb 6, 2025
added 25 commits
February 6, 2025 13:18
added 4 commits
February 6, 2025 13:18
8b5d5ad to
f5c504e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #730
Benchmarks on same input:
goos: darwin
goarch: arm64
mixed res:
panic start with regex - 376828 ns/op
panic start without regex - 2397 ns/op
difference is 157 times
mixed res:
panic continue with regexp - 1257014 ns/op
panic continue without regexp - 16440 ns/op
difference is 76 times
negative res:
panic start with regex - 1441540 ns/op
panic start without regex - 6560 ns/op
difference is 219 times
negative res:
panic continue with regexp - 6450680 ns/op
panic continue without regexp - 46257 ns/op
difference is 139 times