Skip to content

Remove regexps in join_template plugin#731

Merged
goshansmails merged 29 commits intomasterfrom
730-join-template-fast
Feb 6, 2025
Merged

Remove regexps in join_template plugin#731
goshansmails merged 29 commits intomasterfrom
730-join-template-fast

Conversation

@goshansmails
Copy link
Collaborator

@goshansmails goshansmails commented Dec 28, 2024

Fixes #730

Benchmarks on same input:

goos: darwin
goarch: arm64

mixed res:
panic start with regex - 376828 ns/op
panic start without regex - 2397 ns/op
difference is 157 times

mixed res:
panic continue with regexp - 1257014 ns/op
panic continue without regexp - 16440 ns/op
difference is 76 times

negative res:
panic start with regex - 1441540 ns/op
panic start without regex - 6560 ns/op
difference is 219 times

negative res:
panic continue with regexp - 6450680 ns/op
panic continue without regexp - 46257 ns/op
difference is 139 times

@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 91.44737% with 13 lines in your changes missing coverage. Please review.

Project coverage is 73.70%. Comparing base (e02c4a6) to head (4ed0f46).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
plugin/action/join_template/go_panic.go 90.37% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   72.28%   73.70%   +1.42%     
==========================================
  Files         137      145       +8     
  Lines       13985    15347    +1362     
==========================================
+ Hits        10109    11312    +1203     
- Misses       3311     3412     +101     
- Partials      565      623      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goshansmails goshansmails force-pushed the 730-join-template-fast branch from 7f21c37 to c1f78d1 Compare January 20, 2025 08:59
@goshansmails goshansmails force-pushed the 730-join-template-fast branch from c1f78d1 to d951d39 Compare January 28, 2025 10:45
@goshansmails goshansmails force-pushed the 730-join-template-fast branch from 8b5d5ad to f5c504e Compare February 6, 2025 10:19
@goshansmails goshansmails merged commit 1f66e4d into master Feb 6, 2025
8 checks passed
@goshansmails goshansmails deleted the 730-join-template-fast branch February 6, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: remove regexps in join_template plugin

3 participants