Skip to content

Removing dgml and sci file generation#823

Closed
ChristineZh0u wants to merge 2 commits intomasterfrom
pchecker/remove_dgml_sci_files
Closed

Removing dgml and sci file generation#823
ChristineZh0u wants to merge 2 commits intomasterfrom
pchecker/remove_dgml_sci_files

Conversation

@ChristineZh0u
Copy link
Copy Markdown
Contributor

@ChristineZh0u ChristineZh0u commented Mar 4, 2025

  • Removed .sci file generation
  • Cleaned up remaining dgml variables
  • Updated the tutorial expected outputs

if (builder != null)
{
result.CoverageGraph = builder.SnapshotGraph(CheckerConfiguration.IsDgmlBugGraph);
result.CoverageGraph = builder.SnapshotGraph(true);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pass a true value?

var coverageFilePath = $"{filePath}.coverage.txt";
Console.WriteLine($"..... Writing {coverageFilePath}");
codeCoverageReporter.EmitCoverageReport(coverageFilePath);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep the .sci file around. Only remove things related to dgml.

@ankushdesai ankushdesai deleted the pchecker/remove_dgml_sci_files branch April 29, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants