Conversation
Co-authored-by: Christine Zhou <zhouchrs@amazon.com>
cache-actions@v2 has been deprecated and is no longer working; upgraded to the suggested version v4
Upgrade cache action to suggested version
aman-goel
left a comment
aman-goel
left a comment
There was a problem hiding this comment.
Looks mostly good. Needs certain changes (shared in comments).
There was a problem hiding this comment.
Please update pex.yml so that is matches latest changes (like updating cache@v4, etc.).
There was a problem hiding this comment.
We might want to add here something like mvn clean compile -f ./Src/PRuntimes/PExRuntime/pom.xml to build PEx runtime.
There was a problem hiding this comment.
We might want to add here something like mvn clean compile -f ./Src/PRuntimes/PExRuntime/pom.xml to build PEx runtime.
There was a problem hiding this comment.
We might want to add here something like mvn clean compile -f ./Src/PRuntimes/PExRuntime/pom.xml to build PEx runtime.
There was a problem hiding this comment.
We might want to add here something like mvn clean compile -f ./Src/PRuntimes/PExRuntime/pom.xml to build PEx runtime.
| checkerConfiguration.JvmArgs = ((string)option.Value).Replace(':', ' '); | ||
| break; | ||
| case "checker-args": | ||
| case "psym-args": |
There was a problem hiding this comment.
Remove line with "psym-args"
| modes.AllowedValues = new List<string>() { "bugfinding", "verification", "coverage", "pobserve", "stately" }; | ||
| modes.IsHidden = true; | ||
| var modes = Parser.AddArgument("mode", "md", "Compilation mode to use. Can be bugfinding, pex, pobserve, or stately. If this option is not passed, bugfinding mode is used as default"); | ||
| modes.AllowedValues = new List<string>() { "bugfinding", "pex", "pobserve", "stately", "verification", "coverage" }; |
There was a problem hiding this comment.
Remove "verification" or "coverage". Search throughout C# codebase and make sure to remove them.
There was a problem hiding this comment.
Might need to be revisited to update plugins to newer versions.
There was a problem hiding this comment.
Might need to revisit this file, which sets the default PEx runtime config.
There was a problem hiding this comment.
Might need to revisit this file, which controls the PEx CLI options hidden versus visible.
6 participants
dev_p3.0/pex has changes from mainline and dev/pexplicit_checker
This PR merges all the changes from dev_p3.0/pex