Skip to content

Fix logs path missing in console output#828

Merged
ChristineZh0u merged 2 commits intomasterfrom
fix/console_output_log_path
Mar 11, 2025
Merged

Fix logs path missing in console output#828
ChristineZh0u merged 2 commits intomasterfrom
fix/console_output_log_path

Conversation

@ChristineZh0u
Copy link
Copy Markdown
Contributor

  • Fixed logs path missing in console output
  • Spec violation runs will print in console like below:
 Checker found a bug.
... Emitting traces:
..... Writing PCheckerOutput/BugFinding/generatedOutput_0_0.txt
..... Writing PCheckerOutput/BugFinding/generatedOutput_0_0.trace.json
..... Writing PCheckerOutput/BugFinding/generatedOutput_0_0.schedule
... Elapsed 0.06 sec and used 0 GB.
... Emitting coverage report:
..... Writing PCheckerOutput/BugFinding/generatedOutput.coverage.txt
..... Writing PCheckerOutput/BugFinding/generatedOutput.sci
... Checking statistics:
..... Found 1 bug.
... Scheduling statistics:
..... Explored 1 schedule
..... Found 100.00% buggy schedules.
..... Number of scheduling points in terminating schedules: 2 (min), 2 (avg), 2 (max).
..... Writing PCheckerOutput/BugFinding/generatedOutput_pchecker_summary.txt
... Elapsed 0.1007726 sec.
  • Removed timeline printing in console until feedback strategy is stable

@ankushdesai ankushdesai self-requested a review March 11, 2025 02:23

// we want the graph generation even if doing full exploration.
if ((!_checkerConfiguration.PerformFullExploration && TestingEngine.TestReport.NumOfFoundBugs > 0) ||
(_checkerConfiguration.IsDgmlGraphEnabled && !_checkerConfiguration.IsDgmlBugGraph))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need the DGML graph part of the code; we dont support that anymore

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And hence the comment also does not make sense.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed comment and DGML graph code

@ChristineZh0u ChristineZh0u force-pushed the fix/console_output_log_path branch from 20accbc to f023d62 Compare March 11, 2025 16:56
@ChristineZh0u ChristineZh0u merged commit 44c806c into master Mar 11, 2025
8 checks passed
@ChristineZh0u ChristineZh0u deleted the fix/console_output_log_path branch March 11, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants